Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support arbitrary length hosts #21

Closed
pbostrom opened this issue Oct 19, 2018 · 0 comments
Closed

support arbitrary length hosts #21

pbostrom opened this issue Oct 19, 2018 · 0 comments

Comments

@pbostrom
Copy link
Contributor

pbostrom commented Oct 19, 2018 •
edited
Loading

The express-subdomain middleware needs to be able to calculate the subdomain for arbitrary length hosts like aragonpm.com or aragonpm-test.aragon.network. The default "subdomain offset" property for express is 2, this needs to be calculated dynamically based on the value of APMSERVE_HOST.
For background see:
bmullan91/express-subdomain#17
bmullan91/express-subdomain#17 (comment)
http://expressjs.com/en/4x/api.html#app.settings.table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pbostrom