Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misconf): change default TLS values for the Azure storage account #7345

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Aug 15, 2024

Description

Now the default minimum TLS value for storage account in Terraform is TLS1_2. But Azure ARM sets the default value depending on the deployment method. If the account is created via ARM, the MinimumTlsVersion property is not set by default and does not return a value until you explicitly set it.

Refs:

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin changed the title fix(azure): change default TLS values for the storage account fix(misconf): change default TLS values for the Azure storage account Aug 15, 2024
@nikpivkin nikpivkin marked this pull request as ready for review August 15, 2024 13:33
@nikpivkin nikpivkin requested a review from simar7 as a code owner August 15, 2024 13:33
@simar7 simar7 added this pull request to the merge queue Aug 15, 2024
Merged via the queue into aquasecurity:main with commit aadb090 Aug 15, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants