Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(misconf): do not convert contents of a YAML file to string #7292

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

nikpivkin
Copy link
Contributor

Description

To work with bytes, it is better to use the bytes package instead of converting bytes to a string.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review August 1, 2024 11:52
@nikpivkin nikpivkin requested a review from simar7 as a code owner August 1, 2024 11:52
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! did you measure how much better this performs? We could add that info to the release notes.

@simar7 simar7 added this pull request to the merge queue Aug 6, 2024
Merged via the queue into aquasecurity:main with commit 85dadf5 Aug 6, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants