fix(terraform): add aws_region name to presets #7184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpivkin
approved these changes
Jul 18, 2024
|
@simar7 There are many resources for which values are predefined. How about adding support for a file where users can specify values for such resources/data blocks? |
|
@albertodonato Can you fix the linter's issues? |
albertodonato
force-pushed
the
preset-aws-region-name
branch
from
f0b56dc to
0766f74
Compare
|
@nikpivkin should be good now |
simar7
approved these changes
Aug 6, 2024
Let's start by documenting this behavior first as I think it also doesn't exist. After that let's see if adding support for users to provide such values makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.