Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): add Locations for Packages in client/server mode #6366

Merged
merged 3 commits into from
Mar 24, 2024

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Mar 21, 2024

Description

We miss Locations for Packages in client/server mode.

Before:

➜ trivy -q fs --server http://localhost:4954 ./pkg/fanal/analyzer/language/nodejs/npm/testdata/happy -f json --list-all-pkgs | grep Locations

After:

➜ trivy -q fs --server http://localhost:4954 ./pkg/fanal/analyzer/language/nodejs/npm/testdata/happy -f json --list-all-pkgs | grep Locations

          "Locations": [
          "Locations": [
          "Locations": [
          "Locations": [
          "Locations": [
          "Locations": [
          "Locations": [

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Mar 21, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review March 21, 2024 09:21
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner March 21, 2024 09:21
@knqyf263 knqyf263 added this pull request to the merge queue Mar 24, 2024
Merged via the queue into aquasecurity:main with commit a2482c1 Mar 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: packages don't contain locations in client/server mode
2 participants