Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misconf): add an image misconf to result #5731

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix(misconf): add an image misconf to result #5731

merged 1 commit into from
Dec 6, 2023

Conversation

nikpivkin
Copy link
Contributor

Description

When adding misconfigurations to the result, we need to check that the image configuration scanner has been enabled.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review December 5, 2023 13:04
@nikpivkin nikpivkin requested a review from knqyf263 as a code owner December 5, 2023 13:04
@simar7 simar7 self-requested a review December 5, 2023 23:38
simar7
simar7 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@knqyf263 knqyf263 added this pull request to the merge queue Dec 6, 2023
Merged via the queue into aquasecurity:main with commit a5342da Dec 6, 2023
12 checks passed
@nikpivkin nikpivkin deleted the img-misconf branch December 18, 2023 13:40
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker image mis-configuration scanning not working
3 participants
@nikpivkin @simar7 @knqyf263