Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --distro flag to manually specify OS distribution for vulnerability scanning #8070

Merged
merged 12 commits into from
Dec 9, 2024

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Dec 9, 2024

Description

Adding --distro. See #8065 for details.

$ trivy image alpine:3.20 --scanners vuln --distro alpine/edge
2024-12-09T11:55:13+04:00       INFO    [vuln] Vulnerability scanning is enabled
2024-12-09T11:55:16+04:00       INFO    Overriding detected OS with provided distro     detected="alpine/3.20.3" provided="alpine/edge"
2024-12-09T11:55:16+04:00       INFO    Detected OS     family="alpine" version="edge"
2024-12-09T11:55:16+04:00       INFO    [alpine] Detecting vulnerabilities...   os_version="edge" repository="" pkg_num=14
2024-12-09T11:55:16+04:00       INFO    Number of language-specific files       num=0

TODOs

  • Add --distro flag
  • Override detected OS
  • Override detected repository
  • Add unit tests
  • Add integration tests
  • Add documentation

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <[email protected]>
@knqyf263 knqyf263 marked this pull request as ready for review December 9, 2024 11:26
@knqyf263 knqyf263 self-assigned this Dec 9, 2024
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DmitriyLewen DmitriyLewen added this pull request to the merge queue Dec 9, 2024
Merged via the queue into aquasecurity:main with commit da17dc7 Dec 9, 2024
17 checks passed
@knqyf263 knqyf263 deleted the add_distro_option branch December 9, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add --distro flag to manually specify OS distribution for vulnerability scanning
2 participants