Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(misconf): generate placeholders for random provider resources #8051

Merged
merged 1 commit into from
Dec 6, 2024
Merged

feat(misconf): generate placeholders for random provider resources #8051

merged 1 commit into from
Dec 6, 2024

Conversation

nikpivkin
Copy link
Contributor

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review December 5, 2024 09:45
@nikpivkin nikpivkin requested a review from simar7 as a code owner December 5, 2024 09:45
simar7
simar7 reviewed Dec 6, 2024
View reviewed changes
pkg/iac/terraform/presets.go
"strings"

"github.com/google/uuid"
"github.com/zclconf/go-cty/cty"
)

var resourceRandomAttributes = map[string][]string{
// If the user leaves the name blank, Terraform will automatically generate a unique name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You left random_pet behind 😿

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random_pet has only an id attribute, which we fill in for all resources :)

@simar7 simar7 added this pull request to the merge queue Dec 6, 2024
Merged via the queue into aquasecurity:main with commit ffe24e1 Dec 6, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Dec 6, 2024
Open
@nikpivkin nikpivkin deleted the rnd-provider branch December 6, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(terraform): support for random provider
2 participants
@nikpivkin @simar7