Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nodejs): respect peer dependencies for dependency tree #7989

Merged
merged 2 commits into from
Dec 5, 2024
Merged

feat(nodejs): respect peer dependencies for dependency tree #7989

merged 2 commits into from
Dec 5, 2024

Conversation

knqyf263
Copy link
Collaborator

Description

Respect peer dependencies for the dependency tree when the package manager lists them in its lock file.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Nov 25, 2024
@knqyf263 knqyf263 changed the title feat(npm): respect peer dependencies for dependency tree feat(nodejs): respect peer dependencies for dependency tree Nov 25, 2024
@knqyf263 knqyf263 marked this pull request as ready for review December 4, 2024 06:57
@knqyf263
Copy link
Collaborator Author

knqyf263 commented Dec 4, 2024

@DmitriyLewen Can you please take a look?

DmitriyLewen
DmitriyLewen approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DmitriyLewen DmitriyLewen added this pull request to the merge queue Dec 5, 2024
Merged via the queue into aquasecurity:main with commit 7389961 Dec 5, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Dec 5, 2024
Open
@knqyf263 knqyf263 deleted the peer_deps branch December 5, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(npm): treat peerDependencies as dependencies
2 participants
@knqyf263 @DmitriyLewen