-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(java): Return error when trying to find a remote pom to avoid segfault #7275
fix(java): Return error when trying to find a remote pom to avoid segfault #7275
Conversation
FAO @DmitriyLewen |
7c058be
to
cef5525
Compare
cef5525
to
2e12a61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @coheigea
Thanks for fast fix.
I'm worried that we'll stop checking out repos instead of moving on to checking out the next repo.
So i refactored a bit.
@aqua-bot backport release/v0.54 |
…fault (#7275) Co-authored-by: DmitriyLewen <[email protected]>
Backport PR created: #7283 |
LGTM thanks! Any chance of a fix in 0.54.1 as it's a regression? |
We are preparing |
On updating from 0.52.x to 0.54.0, Trivy is segfaulting when scanning a maven filesystem due to the changes in 1f8fca1
"Nil" is returned for the error in remoteRepoRequest, and so in fetchPOMFromRemoteRepository it proceeds to client.Do with a null "req".
The fix just returns the error in remoteRepoRequest and so it's handled properly by the calling functions.