Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(misconf): Add support for using spec from on-disk bundle #7179

Merged
merged 3 commits into from
Aug 27, 2024
Merged

feat(misconf): Add support for using spec from on-disk bundle #7179

merged 3 commits into from
Aug 27, 2024

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Jul 17, 2024 •
edited
Loading

Description

Add support for using specs from on-disk bundle

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 force-pushed the spec-from-bundle branch 2 times, most recently from edbe613 to 7a27ae0 Compare August 9, 2024 02:55
@simar7 simar7 marked this pull request as ready for review August 12, 2024 16:15
@simar7 simar7 requested a review from knqyf263 as a code owner August 12, 2024 16:15
@simar7 simar7 requested a review from nikpivkin August 12, 2024 16:15
nikpivkin
nikpivkin reviewed Aug 13, 2024
View reviewed changes
pkg/flag/report_flags.go Outdated Show resolved Hide resolved
@simar7 simar7 removed the request for review from knqyf263 August 21, 2024 21:03
@simar7 simar7 requested a review from nikpivkin August 23, 2024 21:26
nikpivkin
nikpivkin approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@nikpivkin nikpivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simar7 simar7 added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit be86126 Aug 27, 2024
12 checks passed
@simar7 simar7 deleted the spec-from-bundle branch August 27, 2024 00:50
@aqua-bot aqua-bot mentioned this pull request Aug 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikpivkin nikpivkin nikpivkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(misconfig): Load misconfiguration specs from bundles
2 participants
@simar7 @nikpivkin