fix: include packages unless it is not needed #6765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: knqyf263 <[email protected]>
Signed-off-by: knqyf263 <[email protected]>
Signed-off-by: knqyf263 <[email protected]>
Signed-off-by: knqyf263 <[email protected]>
Signed-off-by: knqyf263 <[email protected]>
Signed-off-by: knqyf263 <[email protected]>
Signed-off-by: knqyf263 <[email protected]>
Since packages are always included and filtered out on the client side, we don't havd to send ListAllPackages to the server. Signed-off-by: knqyf263 <[email protected]>
Signed-off-by: knqyf263 <[email protected]>
BorisShek
added a commit
to BorisShek/secureCodeBox
that referenced
this pull request
Nov 12, 2024
…he new version Update snapshot test files. Add a 'Packages' attribute to each result entry to simulate the new Trivy scanner conventions. Set its value as an empty list, as this attribute isnt parsed by the Trivy parser and is only included to match the updated format in Trivy 0.56.0 (aquasecurity/trivy#6765). Signed-off-by: Boris Shek <[email protected]>
4 tasks
Ilyesbdlala
pushed a commit
to secureCodeBox/secureCodeBox
that referenced
this pull request
Nov 19, 2024
Update snapshot test files. Add a 'Packages' attribute to each result entry to simulate the new Trivy scanner conventions. Set its value as an empty list, as this attribute isnt parsed by the Trivy parser and is only included to match the updated format in Trivy 0.56.0 (aquasecurity/trivy#6765). Signed-off-by: Boris Shek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes to always include packages in the internal report by default, regardless of the
--list-all-pkgsflag, as packages are required in many cases during vulnerability scanning, such as the dependency tree and VEX. Currently, filtering by VEX is broken because the package is not included by default. Only if--list-all-pkgsis not specified, the packages are removed from the final JSON output.Checklist