From b65b32ddfa6fc62ac81ad9fa580e1f5a327864f5 Mon Sep 17 00:00:00 2001
From: Nikita Pivkin <nikita.pivkin@smartforce.io>
Date: Sat, 24 Aug 2024 01:59:30 +0600
Subject: [PATCH] fix(misconf): init frameworks before updating them (#7376)

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
---
 pkg/iac/rego/metadata.go      |  3 +++
 pkg/iac/rego/metadata_test.go | 11 +++++++++++
 2 files changed, 14 insertions(+)

diff --git a/pkg/iac/rego/metadata.go b/pkg/iac/rego/metadata.go
index 907b8450bdcb..57602ce97b8c 100644
--- a/pkg/iac/rego/metadata.go
+++ b/pkg/iac/rego/metadata.go
@@ -54,6 +54,9 @@ func NewStaticMetadata(pkgPath string, inputOpt InputOptions) *StaticMetadata {
 }
 
 func (sm *StaticMetadata) Update(meta map[string]any) error {
+	if sm.Frameworks == nil {
+		sm.Frameworks = make(map[framework.Framework][]string)
+	}
 
 	upd := func(field *string, key string) {
 		if raw, ok := meta[key]; ok {
diff --git a/pkg/iac/rego/metadata_test.go b/pkg/iac/rego/metadata_test.go
index 6b4bb9773a92..6535e21c14ac 100644
--- a/pkg/iac/rego/metadata_test.go
+++ b/pkg/iac/rego/metadata_test.go
@@ -97,6 +97,7 @@ func Test_UpdateStaticMetadata(t *testing.T) {
 			References:     []string{"r", "r1_n", "r2_n"},
 			CloudFormation: &scan.EngineMetadata{},
 			Terraform:      &scan.EngineMetadata{},
+			Frameworks:     make(map[framework.Framework][]string),
 		}
 
 		assert.Equal(t, expected, sm)
@@ -114,6 +115,7 @@ func Test_UpdateStaticMetadata(t *testing.T) {
 			References:     []string{"r", "r1_n", "r2_n"},
 			CloudFormation: &scan.EngineMetadata{},
 			Terraform:      &scan.EngineMetadata{},
+			Frameworks:     make(map[framework.Framework][]string),
 		}
 
 		assert.Equal(t, expected, sm)
@@ -131,10 +133,19 @@ func Test_UpdateStaticMetadata(t *testing.T) {
 			Deprecated:     true,
 			CloudFormation: &scan.EngineMetadata{},
 			Terraform:      &scan.EngineMetadata{},
+			Frameworks:     make(map[framework.Framework][]string),
 		}
 
 		assert.Equal(t, expected, sm)
 	})
+
+	t.Run("frameworks is not initialized", func(t *testing.T) {
+		sm := StaticMetadata{}
+		err := sm.Update(map[string]any{
+			"frameworks": map[string]any{"all": []any{"a", "b", "c"}},
+		})
+		require.NoError(t, err)
+	})
 }
 
 func Test_NewEngineMetadata(t *testing.T) {