Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no db-all make target #466

Open
naddeoa opened this issue Nov 12, 2024 · 2 comments
Open

There is no db-all make target #466

naddeoa opened this issue Nov 12, 2024 · 2 comments

Comments

@naddeoa
Copy link

naddeoa commented Nov 12, 2024

The docs say that you can build the trivy db by checking out the repo and running make db-all.

You can utilize `make db-all` to build the database, the DB artifact is outputted to the assets folder.

As far as I can tell, the target was removed in commit 6121d35. I was going to work around it by just building the docker image instead with docker build . -t trivy-db, but that references make db-all also, which implies it doesn't work at all and probably isn't used in general.

The CI file uses the db-build target instead but the README has no instructions for setting up your dev environment to make that actually work locally.

- name: Build database
run: make db-build

Is there another target we should use? Experimentally, I can get it working by recreating what that old deleted target was doing but I'm not sure why I would have to do that.

For context, I'm just trying to build the db to work around the rate limiting issues described in aquasecurity/trivy-action#389

@naddeoa
Copy link
Author

naddeoa commented Nov 12, 2024

Follow up question.

Are the docker and public.ecr.aws repos fair game for the public to use as well? Compared to the ghcr repo they're very underutilized. If I can just add --db-repository public.ecr.aws/aquasecurity/trivy-db:2 to my trivy command and get my images from a non ghcr source then that's probably much easier, unless the AWS one isn't updated as often or has some other issue.

@halamix2
Copy link

halamix2 commented Nov 17, 2024

git log -S db-all points that thsi target was removed in #347
Still, readme and Dockerfile files reference this target

As a workaround, running make build db-fetch-langs db-fetch-vuln-list db-build db-compact db-compress should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants