Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checks): align AVD-AWS-0107 and AVD-AWS-0105 checks with CIS Benchmarks #257

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Sep 20, 2024

This PR includes alignment of AVD-AWS-0107 and AVD-AWS-0105 checks with AWS CIS benchmarks v1.2 and v1.4.

AVD-AWS-0107

Before: The check is triggered if a CIDR defines more than one public IP

Now: The check is triggered if the rule contains a CIDR that defines all available IP addresses, and uses TCP or UDP protocols for SSH or RDP ports.
Severity changed from CRITICAL to HIGH.

Ref:

AVD-AWS-0105

Before: The check is triggered if a CIDR defines more than one public IP

Now: The check is triggered if the rule contains a CIDR that defines all available IP addresses and uses the TCP protocol for SSH or RDP ports. Severity changed from CRITICAL to MEDIUM and check added to aws-cis-1.4 compliance.

Ref:

Fixes:

Related PRs:

simar7
simar7 previously approved these changes Sep 24, 2024
@simar7
Copy link
Member

simar7 commented Sep 24, 2024

@nikpivkin lgtm, should we merge it?

@nikpivkin
Copy link
Contributor Author

@simar7 Can you take a look #256 ?

@simar7
Copy link
Member

simar7 commented Sep 26, 2024

@simar7 Can you take a look #256 ?

merged

@nikpivkin nikpivkin marked this pull request as ready for review September 26, 2024 05:11
@simar7 simar7 enabled auto-merge September 26, 2024 05:13
@simar7 simar7 disabled auto-merge September 26, 2024 05:17
@simar7 simar7 merged commit f7972d6 into aquasecurity:main Sep 26, 2024
5 checks passed
@nikpivkin nikpivkin deleted the cidr-checks branch October 1, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants