Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trivy scan started failing recently for html format #410

Open
SaurabhYadav-Savy opened this issue Oct 11, 2024 · 6 comments · May be fixed by #424
Open

Trivy scan started failing recently for html format #410

SaurabhYadav-Savy opened this issue Oct 11, 2024 · 6 comments · May be fixed by #424

Comments

@SaurabhYadav-Savy
Copy link

Hello,
Recently trivy scan started failing for format template, specifically for html.tpl.
Few days back it was working fine.

Here is the relevant details I'm using in the workflow

     uses: aquasecurity/trivy-action@master
      with:
        scan-type: image
        format: 'template'
        template: '@/contrib/html.tpl'
        output: 'trivy-results.html

Getting error: Fatal error report error: unable to write results: failed to initialize template writer: error retrieving template from path: open /contrib/html.tpl: no such file or directory
Error: Process completed with exit code 1.
@matteovivona
Copy link

I have the same issue. I rolled back to 0.24.0

@ruben-hoenle-fnt
Copy link

same here

@mat-sylvia-mark43
Copy link

I think this is related to my issue from the latest release:
#408 (comment)

@simar7
Copy link
Member

simar7 commented Oct 22, 2024

@DmitriyLewen I would assume this is because the templates used to exist in the Trivy docker image but not by default in the composite action?

@DmitriyLewen
Copy link
Contributor

DmitriyLewen commented Oct 22, 2024 •
edited
Loading

@simar7 you are right.
install script doesn't copy contrib dir...
I can copy contrib dir in setup-trivy.
But I can't select better best to do this.
By default we install Trivy into $HOME/.local/bin/trivy-bin directory.
I can keep contrib in this dir, but i am not sure that this is user friendly.

@simar7 wdyt?

@DmitriyLewen DmitriyLewen mentioned this issue Oct 22, 2024
Merged
@simar7
Copy link
Member

simar7 commented Oct 23, 2024

@simar7 you are right. install script doesn't copy contrib dir... I can copy contrib dir in setup-trivy. But I can't select better best to do this. By default we install Trivy into $HOME/.local/bin/trivy-bin directory. I can keep contrib in this dir, but i am not sure that this is user friendly.

@simar7 wdyt?

Yes I understand. I think it's the best option for now.

@DmitriyLewen DmitriyLewen linked a pull request Oct 24, 2024 that will close this issue
Open
stempler added a commit to wetransform/gha-trivy that referenced this issue Oct 24, 2024
@stempler
fix: fix access broken access to default templates after update
99d93e2 
See aquasecurity/trivy-action#410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bump setup-trivy and add new contrib directory path info DmitriyLewen/trivy-action
6 participants
@simar7 @matteovivona @DmitriyLewen @ruben-hoenle-fnt @SaurabhYadav-Savy @mat-sylvia-mark43