Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prog): align BPFProg API - set_type, set_expected_attach_type #467

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

CodePrometheus
Copy link
Contributor

@CodePrometheus CodePrometheus commented Dec 9, 2024

Close: #223
Close: #224

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2024

CLA assistant check
All committers have signed the CLA.

prog.go Outdated Show resolved Hide resolved
prog.go Outdated Show resolved Hide resolved
prog.go Show resolved Hide resolved
prog.go Outdated Show resolved Hide resolved
prog.go Outdated Show resolved Hide resolved
@geyslan geyslan assigned geyslan and CodePrometheus and unassigned geyslan Dec 9, 2024
@CodePrometheus
Copy link
Contributor Author

Thank you for your detailed and patient review, I have fixed them all, PTAL.

Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put more suggestions.

Take a look in the code base to replace all calls to the about to be deprecated methods with the new API.

prog.go Outdated Show resolved Hide resolved
prog.go Outdated Show resolved Hide resolved
prog.go Outdated Show resolved Hide resolved
prog.go Outdated Show resolved Hide resolved
Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodePrometheus awesome. Thanks for your help on this.

--- EDIT

Feel free to take or open other issues.

@geyslan geyslan changed the title chore(prog): Add error warp chore(prog): align BPFProg API - set_type, set_expected_attach_type Dec 11, 2024
@geyslan geyslan merged commit 79f5509 into aquasecurity:main Dec 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SetAttachType should return an error SetProgramType should return an error
3 participants