Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetProgramType should return an error #223

Closed
grantseltzer opened this issue Aug 24, 2022 · 2 comments · Fixed by #467
Closed

SetProgramType should return an error #223

grantseltzer opened this issue Aug 24, 2022 · 2 comments · Fixed by #467
Labels
API Break

Comments

@grantseltzer
Copy link
Contributor

The underlying libbpf API function bpf_program__set_type() returns a possible error, so should this.
@geyslan geyslan assigned geyslan and josedonizetti and unassigned geyslan May 26, 2023
@geyslan geyslan mentioned this issue May 26, 2023
Closed
@geyslan
Copy link
Member

geyslan commented May 26, 2023

Same effort: #224

@geyslan
Copy link
Member

geyslan commented Dec 9, 2024

@CodePrometheus

@CodePrometheus CodePrometheus mentioned this issue Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Break
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(prog): align BPFProg API - set_type, set_expected_attach_type CodePrometheus/libbpfgo
3 participants
@josedonizetti @geyslan @grantseltzer