Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry temporary errors #829

Open
int128 opened this issue Jun 3, 2022 · 2 comments
Open

Retry temporary errors #829

int128 opened this issue Jun 3, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@int128
Copy link

int128 commented Jun 3, 2022

Feature Overview

We sometimes get a temporary error during download. For example,

time="2022-06-03T07:38:37Z" level=info msg="download and unarchive the package" aqua_version=1.9.0 env=linux/amd64 exe_path=/home/runner/.local/share/aquaproj-aqua/pkgs/github_release/github.com/kubernetes-sigs/kustomize/kustomize/v3.9.4/kustomize_v3.9.4_linux_amd64.tar.gz/kustomize package=kubernetes-sigs/kustomize package_name=kubernetes-sigs/kustomize package_version=kustomize/v3.9.4 program=aqua registry=standard
time="2022-06-03T07:38:38Z" level=fatal msg="aqua failed" aqua_version=1.9.0 env=linux/amd64 error="copy the file to the temporal file: stream error: stream ID 1; PROTOCOL_ERROR; received from peer" program=aqua

It would be nice to retry on temporary errors for better experience.

Why is the feature needed?

We need to rerun a job on a temporary error.

Does the feature include Breaking Changes?

No.

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Jun 3, 2022
@suzuki-shunsuke
Copy link
Member

Thank you for your proposal.
It looks reasonable.
Maybe we should retry the installation if the HTTP response code is greater equal than 500.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants