Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aqua g -i removes comments in array (packages) #3323

Closed
suzuki-shunsuke opened this issue Dec 4, 2024 · 0 comments · Fixed by #3325
Closed

aqua g -i removes comments in array (packages) #3323

suzuki-shunsuke opened this issue Dec 4, 2024 · 0 comments · Fixed by #3325
Labels
bug Something isn't working

Comments

@suzuki-shunsuke
Copy link
Member

aqua info

$ aqua info
{
  "version": "2.38.2",
  "commit_hash": "ae397291f7ee7f5fd3559a123f7a7edf743720df",
  "os": "darwin",
  "arch": "arm64",
  "pwd": "/Users/(USER)/test/aqua/comment",
  "root_dir": "/Users/(USER)/.local/share/aquaproj-aqua",
  "env": {
    "AQUA_PROGRESS_BAR": "true",
    "GITHUB_TOKEN": "(masked)"
  },
  "config_files": [
    {
      "path": "/Users/(USER)/test/aqua/comment/aqua.yaml"
    }
  ]
}

Overview

aqua g -i removes comments in array (packages).

How to reproduce

aqua.yaml

registries:
- type: standard
  ref: v4.267.0 # renovate: depName=aquaproj/aqua-registry
packages:
- name: suzuki-shunsuke/[email protected]
# hello
- name: suzuki-shunsuke/[email protected]

Executed command and output

aqua g -i suzuki-shunsuke/ghalint

Expected behaviour

Comments in packages are kept.

registries:
- type: standard
  ref: v4.267.0 # renovate: depName=aquaproj/aqua-registry
packages:
- name: suzuki-shunsuke/[email protected]
# hello
- name: suzuki-shunsuke/[email protected]
- name: suzuki-shunsuke/[email protected]

Actual behaviour

Comments in packages are removed.

registries:
- type: standard
  ref: v4.267.0 # renovate: depName=aquaproj/aqua-registry
packages:
- name: suzuki-shunsuke/[email protected]
- name: suzuki-shunsuke/[email protected]
- name: suzuki-shunsuke/[email protected]

Note

I created this issue on goccy/go-yaml#502 , got an answer.

Probably we can solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant