Replies: 2 comments
-
Never mind me, this is easy to fix with a try and except. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Hi @jgserra18, Yes this is something I have thought about (i.e., allowing a simulation to contintue even though the GDD's are not enough to reach full maturity), just havent got around to it yet. I believe it did cause problems with other calculations which is which I introuduced the assertion but it has been a while since I looked at that aspect. Feel free to have a go a removing it in a pull request or go ahead with your try/except fix. Tom |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The assertion errors related to crop maturity and the gdd.sum make it impossible to run aquacrop in a grid. This is particularly systematic at a relatively fine resolution. I was thinking it would be a good idea to add an option (e.g., a boolean grid_simulation argument) that would disable the assertion errors. Returning 0 or -999 would be a relatively easy option to stop the model to further simulate in such cases, albeit not quite very elegant (e.g., in compute_crop_calendar --> compute_variables --> initialize --> core.
Beta Was this translation helpful? Give feedback.
All reactions