Feature/sound #125
Open
Feature/sound #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a new feature to the Toastify library, allowing users to add sound support to toast notifications. The feature enhances user engagement and provides audio cues for important notifications. The PR includes the necessary code changes to enable sound functionality and updates the README file with documentation and usage examples.
Changes Made:
Added support for sound in the Toastify library.
Implemented the ability to specify custom sound files or use default sounds.
Updated the README file with detailed documentation and usage examples for the new sound feature.
Testing Done:
✔️ Created test cases to verify the correct behaviour of sound functionality.
✔️ Tested the feature with different sound types and custom sound files.
✔️ Verified that toast notifications display with the appropriate sound.
✔️ Please review and merge this PR. It adds valuable functionality to the Toastify library and improves the overall user experience.
Thank you!