Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base-gas.md #9316

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Update base-gas.md #9316

merged 2 commits into from
Aug 5, 2023

Conversation

cryptomolot
Copy link
Contributor

Changed link on the correct folder

@cryptomolot
Update base-gas.md
d691bec 
Changed link on the correct folder
@cryptomolot cryptomolot requested a review from saharct as a code owner July 26, 2023 10:33
saharct
saharct approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@saharct saharct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

vgao1996
vgao1996 approved these changes Jul 27, 2023 •
edited
Loading
View reviewed changes
developer-docs-site/docs/concepts/base-gas.md Outdated
@@ -338,7 +338,7 @@ Hence in practice, payload gas is unlikely to be a concern.
[BCS sequence specification]: https://github.com/diem/bcs#fixed-and-variable-length-sequences
[`gas_meter.rs`]: https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/aptos-gas/src/gas_meter.rs
[`initialize()`]: https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/framework/aptos-framework/doc/storage_gas.md#0x1_storage_gas_initialize
[`instr.rs`]: https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/aptos-gas/src/instr.rs
[`instr.rs`]: https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/aptos-gas-schedule/src/gas_schedule/instr.rs
Copy link
Contributor

@vgao1996 vgao1996 Jul 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! Can we also fix similar links that got broken by the recent removal of aptos-gas crate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, #9317 is a start. Would you mind if I change some parametres too since they are different now compared to April version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be awesome!

@gregnazario gregnazario enabled auto-merge (squash) August 5, 2023 01:29
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

✅ Forge suite compat success on aptos-node-v1.5.1 ==> 52431c80319832d682e9eeb5925850efeed7f84d

Compatibility test results for aptos-node-v1.5.1 ==> 52431c80319832d682e9eeb5925850efeed7f84d (PR)
1. Check liveness of validators at old version: aptos-node-v1.5.1
compatibility::simple-validator-upgrade::liveness-check : committed: 4351 txn/s, latency: 7156 ms, (p50: 6400 ms, p90: 10300 ms, p99: 19600 ms), latency samples: 182780
2. Upgrading first Validator to new version: 52431c80319832d682e9eeb5925850efeed7f84d
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1847 txn/s, latency: 15855 ms, (p50: 18600 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92360
3. Upgrading rest of first batch to new version: 52431c80319832d682e9eeb5925850efeed7f84d
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1758 txn/s, latency: 15533 ms, (p50: 19000 ms, p90: 21700 ms, p99: 22300 ms), latency samples: 91440
4. upgrading second batch to new version: 52431c80319832d682e9eeb5925850efeed7f84d
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3284 txn/s, latency: 9498 ms, (p50: 9900 ms, p90: 13800 ms, p99: 14200 ms), latency samples: 137960
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 52431c80319832d682e9eeb5925850efeed7f84d passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

✅ Forge suite realistic_env_max_load success on 52431c80319832d682e9eeb5925850efeed7f84d

two traffics test: inner traffic : committed: 6453 txn/s, latency: 6077 ms, (p50: 5800 ms, p90: 7500 ms, p99: 12300 ms), latency samples: 2787880
two traffics test : committed: 100 txn/s, latency: 2994 ms, (p50: 2900 ms, p90: 3400 ms, p99: 7800 ms), latency samples: 1840
Max round gap was 1 [limit 4] at version 1303338. Max no progress secs was 3.800724 [limit 10] at version 1303338.
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 52431c80319832d682e9eeb5925850efeed7f84d

Compatibility test results for aptos-node-v1.5.1 ==> 52431c80319832d682e9eeb5925850efeed7f84d (PR)
Upgrade the nodes to version: 52431c80319832d682e9eeb5925850efeed7f84d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 3288 txn/s, latency: 6697 ms, (p50: 6500 ms, p90: 9900 ms, p99: 11100 ms), latency samples: 180840
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 52431c80319832d682e9eeb5925850efeed7f84d passed
Test Ok

@gregnazario gregnazario merged commit 7091fbf into aptos-labs:main Aug 5, 2023
xbtmatt pushed a commit that referenced this pull request Aug 13, 2023
@cryptomolot @gregnazario @xbtmatt
Update base-gas.md (#9316)
fa8a68e 
Changed link on the correct folder

Co-authored-by: Greg Nazario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgao1996 vgao1996 vgao1996 approved these changes

@saharct saharct saharct approved these changes

@davidiw davidiw Awaiting requested review from davidiw

@movekevin movekevin Awaiting requested review from movekevin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cryptomolot @vgao1996 @saharct @gregnazario