-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make LayeredMap address leaves by the hash value of the key #14021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9557ac9
to
2b541ca
Compare
609cf8b
to
cab6410
Compare
cab6410
to
f27dc7d
Compare
zekun000
approved these changes
Jul 18, 2024
grao1991
approved these changes
Jul 18, 2024
areshand
approved these changes
Jul 18, 2024
f27dc7d
to
ea0b249
Compare
1. no longer require the key's binary format to be unique and prefix-free 2. no longer require key's binary format to be in a uniform distribution and doesn't require the keys to start differ "early" (at the first bits) to be efficient all we require now is the key is hashable, the tree will be organized by the hash value bits instead of the key bits
ea0b249
to
7705a41
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prefix-free
distribution and doesn't require the keys to start differ
"early" (at the first bits) to be efficient
all we require now is the key is hashable, the tree will be organized by
the hash value bits instead of the key bits
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
unit tests
and rebase my experiments (of inc hash and no hash) on top of it