Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [compiler-v2] Discuss and resolve the "invalid call" language with a larger group to get closure #9863

Closed
brmataptos opened this issue Aug 31, 2023 · 1 comment · Fixed by #12274 or #12956
Closed

[Bug] [compiler-v2] Discuss and resolve the "invalid call" language with a larger group to get closure #9863

brmataptos opened this issue Aug 31, 2023 · 1 comment · Fixed by #12274 or #12956
Assignees
@wrwg @brmataptos
Labels
bug Something isn't working compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@brmataptos
Copy link
Contributor

🐛 Bug

Compiler v2 is currently emitting error messages like

error: invalid call of `+`: expected `integer` but found `address` for argument 2
   ┌─ tests/checking/typing/binary_add_invalid.move:15:9
   │
15 │         1 + false + @0x0 + 0;
   │         ^^^^^^^^^^^^^^^^

which I object to because '+' is not a function to be called, it's an operator. Wolfgang disagrees. To not waste time, I shelved the issue but we should at least discuss it with some potential developers.

To reproduce

See
third_party/move/move-compiler-v2/tests/checking/typing/binary_add_invalid.exp

in this PR: #9792

Previous discussion may still be available here:

#9792 (comment)
@brmataptos brmataptos added the bug Something isn't working label Aug 31, 2023
@brmataptos brmataptos self-assigned this Aug 31, 2023
@brmataptos brmataptos mentioned this issue Aug 31, 2023
Merged
@sausagee sausagee added the stale-exempt Prevents issues from being automatically marked and closed as stale label Sep 19, 2023
@lbmeiyi lbmeiyi moved this from 🆕 New to 📋 Backlog in Move Language and Runtime Oct 4, 2023
@vineethk vineethk mentioned this issue Oct 17, 2023
Closed
@wrwg wrwg mentioned this issue Feb 28, 2024
Merged
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Move Language and Runtime Mar 2, 2024
@brmataptos brmataptos reopened this Apr 20, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 📋 Backlog in Move Language and Runtime Apr 20, 2024
@brmataptos
Copy link
Contributor Author

Oops, had a stray old test output file.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Move Language and Runtime Apr 20, 2024
@brmataptos brmataptos mentioned this issue Apr 20, 2024
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wrwg wrwg

@brmataptos brmataptos

Labels
bug Something isn't working compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Move Language and Runtime
Status: ✅ Done
Milestone
No milestone
3 participants
@sausagee @wrwg @brmataptos