Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS SDK] support fungible token transfer method #8628

Closed
0xmaayan opened this issue Jun 12, 2023 · 2 comments
Closed

[TS SDK] support fungible token transfer method #8628

0xmaayan opened this issue Jun 12, 2023 · 2 comments
Assignees
@0xmaayan
Labels
sdk SDK related issues stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@0xmaayan
Copy link
Contributor

transfer a fungible token is the same operation as transfer a fungible asset from primary store. With that, we want to support itin a nice dev exp.

on [transferTokwnOwnership()](https://github.com/aptos-labs/aptos-core/blob/main/ecosystem/typescript/sdk/src/plugins/aptos_token.ts#L470) method, add support to accept an optional amount field and transfer fungible token by calling FungibleAssetClass.transferFromPrimaryStore(). nite: can use function overloading.
@0xmaayan 0xmaayan converted this from a draft issue Jun 12, 2023
@0xmaayan 0xmaayan self-assigned this Jun 12, 2023
@0xmaayan 0xmaayan moved this from 🏗 In progress to 👀 In review in Developer Platform Jun 12, 2023
@thepomeranian thepomeranian added the sdk SDK related issues label Jun 15, 2023
@0xmaayan 0xmaayan moved this from 👀 In review to ✅ Done in Developer Platform Jun 27, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Jul 31, 2023
@lbmeiyi lbmeiyi added stale-exempt Prevents issues from being automatically marked and closed as stale and removed Stale labels Aug 7, 2023
@Abuchtela Abuchtela mentioned this issue Sep 21, 2023
Closed
@gregnazario
Copy link
Contributor

SDK v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xmaayan 0xmaayan

Labels
sdk SDK related issues stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Developer Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gregnazario @thepomeranian @0xmaayan @lbmeiyi