Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when packages can't be downloaded #8553

Closed
banool opened this issue Jun 7, 2023 · 1 comment
Closed

Improve error message when packages can't be downloaded #8553

banool opened this issue Jun 7, 2023 · 1 comment
Labels
CLI enhancement New feature or request move-cli Issues related to aptos move command move-deps ops week

Comments

@banool
Copy link
Contributor

banool commented Jun 7, 2023

Repro

# Disallow writes to the `.move` directory.
$ rm -rf ~/.move/
$ mkdir ~/.move
$ chmod 555 ~/.move

# Try to publish
$ ~/a/core/target/debug/aptos move compile --named-addresses token_objects=0x1
Compiling, may take a little while to download git dependencies...
FETCHING GIT DEPENDENCY https://github.com/aptos-labs/aptos-core.git
{
  "Error": "Move compilation failed: Unable to resolve packages for package 'TokenObjects': While resolving dependency 'AptosFramework' in package 'TokenObjects': While processing dependency 'AptosFramework': Unable to find package manifest for 'AptosFramework' at \"/Users/dport/.move/https___github_com_aptos-labs_aptos-core_git_mainnet/aptos-move/framework/aptos-framework\""
}

This error doesn't really explain the root cause, it'd be better to do an explicit check if writes are possible first and raise an error based on that.

@banool
Copy link
Contributor Author

banool commented Jun 20, 2023

Rolled into #8707.

@banool banool closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2023
@github-project-automation github-project-automation bot moved this from 🦆 Todo to ✅ Done in Developer Platform Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement New feature or request move-cli Issues related to aptos move command move-deps ops week
Projects
Archived in project
Development

No branches or pull requests

2 participants