Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API][v1] Unify MIME types #2275

Closed
banool opened this issue Jul 27, 2022 · 2 comments
Closed

[API][v1] Unify MIME types #2275

banool opened this issue Jul 27, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@banool
Copy link
Contributor

banool commented Jul 27, 2022

Currently we use a mix of mime types for BCS:

  • application/x-bcs
  • application/x.aptos.signed_transaction+bcs
  • application/x.aptos.output+bcs

I think we should just cut over to using only the first one, I don't think it's necessary to signal more information with the content type.

@gregnazario
Copy link
Contributor

There's one for input and one for output now, and we'll stick with it for now

@ghost
Copy link

ghost commented Feb 13, 2023

// TODO: Since I don't want to impl all the Poem derives on SignedTransaction,
// find a way to at least indicate in the spec that it expects a SignedTransaction.
// TODO: https://github.com/aptos-labs/aptos-core/issues/2275

👀 the todo comment still exists on this moment now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants