Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][move-compiler-v2] v2 missed some mutable borrow errors #14628

Open
brmataptos opened this issue Sep 13, 2024 · 2 comments
Open

[Bug][move-compiler-v2] v2 missed some mutable borrow errors #14628

brmataptos opened this issue Sep 13, 2024 · 2 comments
Labels
bug Something isn't working compiler-v2-stable compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@brmataptos
Copy link
Contributor

🐛 Bug

V1 and V2 outputs for these tests differ significantly:

  • third_party/move/move-compiler/tests/move_check/typing/mutable_borrow_from_immutable.exp
  • third_party/move/move-compiler-v2/tests/reference-safety/v1-typing/mutable_borrow_from_immutable.exp

In particular, V2 is missing errors at lines 11, 15, 16.

Splitting the test into multiple functions (as part of PR #14578) reveals the error at line 11 to V2, but the ones at 15 & 16 are still missing (now would be at line 24 & 25):

  • third_party/move/move-compiler/tests/move_check/typing/mutable_borrow_from_immutable2.exp
  • third_party/move/move-compiler-v2/tests/reference-safety/v1-typing/mutable_borrow_from_immutable2.exp
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Oct 29, 2024
@wrwg wrwg added stale-exempt Prevents issues from being automatically marked and closed as stale and removed Stale labels Oct 31, 2024
@wrwg wrwg moved this from 🆕 New to For Grabs in Move Language and Runtime Oct 31, 2024
@wrwg
Copy link
Contributor

wrwg commented Oct 31, 2024

Need to verify whether it is just error shadowing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler-v2-stable compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Status: For Grabs
Development

No branches or pull requests

2 participants