Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][compiler-v2] Re-enable uninitialized checker for "simplifier-full" tests after fixing them #12830

Closed
vineethk opened this issue Apr 9, 2024 · 1 comment · Fixed by #12831
Closed

[Bug][compiler-v2] Re-enable uninitialized checker for "simplifier-full" tests after fixing them #12830

vineethk opened this issue Apr 9, 2024 · 1 comment · Fixed by #12831
Labels
bug Something isn't working

Comments

@vineethk
Copy link
Contributor

vineethk commented Apr 9, 2024

🐛 Bug

Currently, we seem to disable uninitialized checker for "simplifier-full" tests (with a "TODO: this check should not need to be turned off, but some tests rely on it. Those tests should be fixed".

Because of this, bytecode verification fails for some of the tests.

For relevant code, see third_party/move/move-compiler-v2/tests/testsuite.rs and search for "simplifier-full".
@vineethk vineethk added the bug Something isn't working label Apr 9, 2024
@vineethk
Copy link
Contributor Author

vineethk commented Apr 9, 2024

I re-enabled the checker in this PR: #12831.

@vineethk vineethk mentioned this issue Apr 9, 2024
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Move Language and Runtime Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Move Language and Runtime
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[compiler-v2] Adding full compiler pipeline to many test configs aptos-labs/aptos-core
1 participant
@vineethk