From 2bf1e5a9e78066b05d7deec2a3d9f8ba6b29dbb5 Mon Sep 17 00:00:00 2001 From: Daniel Porteous Date: Thu, 10 Aug 2023 15:34:59 -0700 Subject: [PATCH] Fix node compatibility test CI --- .github/workflows/docker-build-test.yaml | 3 ++- .github/workflows/node-api-compatibility-tests.yaml | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/docker-build-test.yaml b/.github/workflows/docker-build-test.yaml index 7240ca7a97a49f..14ab07c9819d57 100644 --- a/.github/workflows/docker-build-test.yaml +++ b/.github/workflows/docker-build-test.yaml @@ -23,7 +23,8 @@ name: "Build+Test Docker Images" on: # build on main branch OR when a PR is labeled with `CICD:build-images` # Allow us to run this specific workflow without a PR workflow_dispatch: - pull_request_target: + # todo undo + pull_request: types: [labeled, opened, synchronize, reopened, auto_merge_enabled] push: branches: diff --git a/.github/workflows/node-api-compatibility-tests.yaml b/.github/workflows/node-api-compatibility-tests.yaml index cfd01e7fd58631..9e86168fd973aa 100644 --- a/.github/workflows/node-api-compatibility-tests.yaml +++ b/.github/workflows/node-api-compatibility-tests.yaml @@ -114,8 +114,10 @@ jobs: if: ${{ !inputs.SKIP_JOB }} # Ensure any changes to the generated client were checked in. - - run: | - cd ./ecosystem/typescript/sdk && pnpm generate-client -o /tmp/generated_client + - run: cd ./ecosystem/typescript/sdk && pnpm generate-client -o /tmp/generated_client + if: ${{ !inputs.SKIP_JOB }} + + - run: echo "If this step fails, run the following command locally to fix it:" echo "cd ecosystem/typescript/sdk && pnpm generate-client" git diff --no-index --ignore-space-at-eol --ignore-blank-lines ./ecosystem/typescript/sdk/src/generated/ /tmp/generated_client/