-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIP-62][Discussion] Aptos Wallet Standard #306
Comments
@0xmaayan I see on the AIP the account enum
Is there any change multisig v2 could be incorporated here? |
Hi @alnoki AptosAccountVariant enum represents the Signer signing scheme. A multisig account does not have a public key and it holds multi signatures that can be of any signing scheme. Could you clarify the added value on adding it to this enum? |
@0xmaayan understood that the multisig v2 doesn't have a native signature scheme and that votes can be cast with any of the above. Mainly I was interested in potentially allowing approval votes via the wallet adapter, but understood if that is prohibitively complex |
@alnoki gotcha! we can definitely talk on what is missing and we should add to the adapter! Feel free to open an issue on the adapter repo so we can keep track on that! https://github.com/aptos-labs/aptos-wallet-adapter/issues |
@0xmaayan here you go! aptos-labs/aptos-wallet-adapter#241 |
With the The second issue is that while using the |
There are some ways to work around it, but best would be to have changes at the simulation API level where the public key is not required.
Well, if the wallet signs and dapp submits, it is not a wallet adapter issue. One option would be to use the wallet |
AIP Discussion
The Wallet standard defines a universal API for wallet and application interactions. This AIP introduces a new wallet standard for the Aptos ecosystem.
Most web wallets today come in the form of browser extensions. These extensions interact with dApps by injecting themselves to the global window object and exepct a dapp to detect them by reading the window object. There are several issues with the way it works today.
In addition, there are some problems with how the standard is implemented in the Aptos ecosystem these days.
In this proposal, we suggest bringing a generalized event-based model communication between a wallet and a dapp to Aptos that eliminates all the above issues.
Read more about it here: https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-62.md
The text was updated successfully, but these errors were encountered: