Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIP-48][Discussion] Allow direct commission change vesting contract #237

Closed
movekevin opened this issue Aug 24, 2023 · 2 comments
Closed

Comments

@movekevin
Copy link
Contributor

movekevin commented Aug 24, 2023

AIP Discussion

The commission rate cannot be directly changed for a vesting contract after it's been created.
Vesting contract owner can currently get around this by updating the operator and commission rate to a temporary
different operator address, and then change it back in order to only change the commission rate. This can lead to potential validator node downtime.
This proposes allowing the vesting contract owner to change the commission directly while keeping the same operator.

Read more about it here: https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-48.md

@movekevin movekevin changed the title [AIP-46][Discussion] Allow direct commission change vesting contract [AIP-48][Discussion] Allow direct commission change vesting contract Aug 24, 2023
@thepomeranian thepomeranian added this to the aptos-node-v1.7 milestone Sep 6, 2023
@alnoki
Copy link
Contributor

alnoki commented Sep 7, 2023

@movekevin any thoughts on post-hoc commision configuration serving as a rug pull of sorts?

If someone enters into a vesting contract it is typically under the presumption of fixed parameters, not as as subject to the unilateral authority of an executor

@junkil-park
Copy link
Contributor

@alnoki , changing the operator address and commission percentage has been possible from the beginning, through update_operator. This specific AIP allows the admin to conveniently change the operator commission percentage. This has been a requested feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants