Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update all integration covers from PNG to JPG #1179

Closed
wants to merge 1 commit into from

Conversation

adityaoberai
Copy link
Member

What does this PR do?

Updates all integration covers from PNG to JPG

Test Plan

  • pnpm i && pnpm run dev

Related PRs and Issues

#1041

Have you read the Contributing Guidelines on issues?

Yes

@adityaoberai adityaoberai requested a review from ArmanNik August 6, 2024 19:41
@TorstenDittmann
Copy link
Contributor

Why are we moving all images to jpeg?

@adityaoberai
Copy link
Member Author

adityaoberai commented Aug 7, 2024

Why are we moving all images to jpeg?

@TorstenDittmann Ebenezer and Jade noticed white lines coming up when Twitter autoloaded the cover as the image on posts

https://discord.com/channels/938747207446839356/938766768023949326/1270017570128400455

This looks to be triggered by autoconversion from PNG to JPG. Exporting in JPG fixed this issue though

@TorstenDittmann
Copy link
Contributor

Closing this due to optimizations I did in another PR 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants