Fix TOC on Desktop & Mobile
#1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loks0n
reviewed
Aug 23, 2024
ernstmul
reviewed
Nov 25, 2024
Comment on lines
+17
to
+39
| function slideFade( | ||
| node: HTMLElement, | ||
| { | ||
| delay = 0, | ||
| duration = 400, | ||
| easing = cubicOut | ||
| }: { delay?: number; duration?: number; easing?: (t: number) => number } = {} | ||
| ) { | ||
| const initialHeight = node.offsetHeight; | ||
|
|
||
| return { | ||
| delay, | ||
| duration, | ||
| easing, | ||
| css: (t: number) => { | ||
| return ` | ||
| opacity: ${t}; | ||
| height: ${t * initialHeight}px; | ||
| overflow: hidden; | ||
| `; | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
Can we also do this animation with CSS? I think that would better fit the direction we're moving in. Wdyt @thejessewinton?
There was a problem hiding this comment.
Not sure if we probably can (due to t * initialHeight, but correct me if I am wrong), but I think I've seen a similar use-case somewhere around the repo. Lmk what we decide.
There was a problem hiding this comment.
ping @ernstmul @thejessewinton.
ernstmul
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per the discussions, TOC should not show on desktops. Also fixes broken on mobile.
Test Plan
Manual.
Related PRs and Issues
N/A.
Have you read the Contributing Guidelines on issues?
Yes.