-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat implement whatsapp with vonage bun #252
Feat implement whatsapp with vonage bun #252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I see a few issues.
- you've nested this under bun/starter, which is not entirely correct
- You've created a standalone express server, this should be an Appwrite Function
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I'm spending a lot of time going back and forth with this PR - please try to address all my comments before resubmitting for review.
@loks0n , but what will happen to the event webhook ,If I remove this then incoming event webhooks will not be addressed and in documentation it is written that the webhook must be responded with 2XX response and if not done the request will be retried ... so will it not cause any problem and is it efficient to not account the webhooks giving us the status of message ? Documentation -https://developer.vonage.com/en/api/messages-olympus#websockets |
Please review this ! @loks0n |
@loks0n updated ! |
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
@gewenyu99 ,
|
Hey , @gewenyu99, I have not been contacted for the swags yet :) |
Hey Parth |
hey @gewenyu99 @Haimantika @loks0n , i have raised the PR please review it !!
This is a video demonstrating the bun whatsapp bot with vonagee-api
video_demo.mp4