Unit Tests - Node #736
Unit Tests - Node #736
Conversation
mvarendorff
force-pushed
the
feat-680-add-unit-tests-node
branch
from
3629a9c
to
17b7006
Compare
mvarendorff
force-pushed
the
feat-680-add-unit-tests-node
branch
from
17b7006
to
e4dbb20
Compare
|
Are you make these test run automatically with the existing tests? |
|
@abnegate No, and I wasn't aware that was part of the task, sorry! Same answer goes for the other PRs from me you commented on. Since there currently seems to be a fairly central point of testing which is broken up by these PRs, it might make sense to overhaul it in one go at some point? Two of the Unit Tests PRs (PHP and Deno) are also affected. Edit: I just double checked to see why that went under my radar and it seems that the PR referenced in the original issue also did not include any automatic testing, so in addition to PHP and Deno, Flutter + Dart are also affected. |
|
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
|
@abnegate these tests are to be run on |
@lohanidamodar, for Flutter and Dart, we run them in this repo. I think it makes sense to run them in this repo to catch any problems early before pushing to the |
What does this PR do?
This PR adds generated unit tests to the Node SDK.
Test Plan
Generate the SDK, then run run
yarn installandyarn jest(or the equivalents for your favourite package manager) in the directory of the generated SDK.Related PRs and Issues
#680
Have you read the Contributing Guidelines on issues?
Yup
Discord username for swag as requested by Tessa: yestheory