-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat .NET Server SDK updates #320
Conversation
…eat-dotnet-response-models
…e-models # Conflicts: # templates/dotnet/docs/example.md.twig # templates/dotnet/src/Appwrite/Services/ServiceTemplate.cs.twig
@eldadfux @lohanidamodar Would love to get this merged soon if we can 🙏 |
@abnegate can you get this synced with latest changes? |
@lohanidamodar Updated, only Deno tests still failing |
# Conflicts: # .travis.yml
Hi, I saw this PR only after troubleshooting the reason for the currently published NuGet package not working. Just 2 cents and genuine questions I see a big effort ongoing here but also some changes that get me ask "why?". For example: the greatest feature of Net Standard is the compatibility with both Net Framework and Net Core, why having so many targets in the project when netstandard2.0 gives you the best compatibility with any Framework that is not End Of Life? I see both great things and not-so-great things in a huge amount of commits going back to October 2021, generating a new question: if the currently published NuGet package does not work, why not updating the SDK generator a bit at a time? At least the updates are more under control. |
Hey @pietrodicaprio 👋 the many platforms were added to support developers who might not be able to use the latest platforms for whatever reason. In terms of size - this PR has certainly grown a lot over time! It was initially intended as an incremental update, but as new features were added in new releases of Appwrite, those new features had to be supported so this PR could be merged. Hoping to get this merged soon 🤞 |
@abnegate but a csproj like that would require the dev to have multiple SDKs installed. Would be easier to put one and let the dev change it to whatever has available when tries to build. |
@abnegate just double checking, do we have any framework or platform specific code in the Appwrite .NET SDK that requires us to multi-target? Also, are we targetting any particular .NET version that needs us to target |
@pietrodicaprio @adityaoberai I've updated the target frameworks based on the current Microsoft recommendations 👍 |
@abnegate please fix the conflict and I'll merge once @adityaoberai is able to review. |
I looked at the updates and so far, it all looks good. One thing though, this would have to incorporate the fix for chunked uploads made in #648 as well, right? |
…e-models # Conflicts: # templates/dotnet/docs/example.md.twig
Up to date for 1.3.x