Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a consistent user-agent header to all the SDKs #48

Closed
eldadfux opened this issue Jul 10, 2020 · 3 comments
Closed

Add a consistent user-agent header to all the SDKs #48

eldadfux opened this issue Jul 10, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues that can win you some cool merchandise!

Comments

@eldadfux
Copy link
Member

We need to add a consistent user-agent header that will be sent with any HTTP request made by any of our SDKs HTTP clients.

All the user-agent headers should follow the same standard to allow us to parse them easily on the server side in order to get info about the end client platform name, version, and technology.

Any suggestion for the header format will be appreciated.

@eldadfux eldadfux self-assigned this Jul 26, 2020
@eldadfux eldadfux added enhancement New feature or request good first issue Good for newcomers labels Jul 26, 2020
@eldadfux eldadfux added the hacktoberfest Issues that can win you some cool merchandise! label Oct 2, 2020
@stnguyen90
Copy link
Contributor

@eldadfux can this be closed now?

@stnguyen90
Copy link
Contributor

@lohanidamodar, can this be closed now?

@lohanidamodar
Copy link
Member

Closing as this is now merged. We can reopen separate issue if we want any further enhancements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues that can win you some cool merchandise!
Projects
None yet
Development

No branches or pull requests

3 participants