Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

Spotify OAuth Doc #403

Open
wants to merge 4 commits into
base: oauth-providers
Choose a base branch
from

Conversation

asutoshranjan
Copy link

What does this PR do?

Added Spotify OAuth Doc

Copy link
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change ;)


client
.setEndpoint('https://cloud.appwrite.io/v1') // Your API Endpoint
.setProject('[PROJECT_ID]') // Your project ID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't your fault, I think my examples are wrong, too, but:

client
    .setEndpoint('https://cloud.appwrite.io/v1')  // Your API Endpoint
    .setProject('[PROJECT_ID]')                          // Your project ID

See if you can align the comments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I will do that 😄

app/views/docs/oauth-providers/spotify.md Outdated Show resolved Hide resolved
app/views/docs/oauth-providers/spotify.md Outdated Show resolved Hide resolved
@asutoshranjan asutoshranjan requested a review from gewenyu99 August 3, 2023 14:27
Copy link

@Haimantika Haimantika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments need to be aligned

@@ -36,7 +36,7 @@ const account = new Account(client);

client
.setEndpoint('https://cloud.appwrite.io/v1') // Your API Endpoint
.setProject('[PROJECT_ID]') // Your project ID
.setProject('[PROJECT_ID]') // Your Project ID

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment still doesn't look aligned. Can you please recheck? @asutoshranjan

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely! checking it

@@ -99,7 +99,7 @@ void main() async {

client
.setEndpoint('https://cloud.appwrite.io/v1') // YOUR API Endpoint
.setProject('[PROJECT_ID]') // YOUR PROJECT ID
.setProject('[PROJECT_ID]') // YOUR PROJECT ID

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

app/views/docs/oauth-providers/spotify.md Outdated Show resolved Hide resolved
Copy link

@Haimantika Haimantika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine to me.

Copy link

@Haimantika Haimantika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants