Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: session renewal #7452

Merged
merged 9 commits into from
Jan 22, 2024
Merged

Feat: session renewal #7452

merged 9 commits into from
Jan 22, 2024

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Jan 15, 2024

What does this PR do?

Allows session renewal to extend it's expiry date. Very useful for when the session duration is set to short like 5 min.

Test Plan

  • New time-sensitive tests

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments

Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last set of comments and then we can merge

@christyjacob4 christyjacob4 merged commit 3656be3 into 1.5.x Jan 22, 2024
21 checks passed
@stnguyen90 stnguyen90 deleted the feat-session-renewal branch April 25, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants