Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Add Minio support (extend s3) #7282

Open
2 tasks done
RealFascinated opened this issue Dec 13, 2023 · 8 comments
Open
2 tasks done

🚀 Feature: Add Minio support (extend s3) #7282

RealFascinated opened this issue Dec 13, 2023 · 8 comments
Labels
product / storage Fixes and upgrades for the Appwrite Storage.

Comments

@RealFascinated
Copy link

🔖 Feature description

Add a host option to the s3 adapter

🎤 Pitch

There is no way of changing the s3 host provider, so minio is currently unsupported

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@stnguyen90
Copy link
Contributor

Related utopia-php/storage issue: utopia-php/storage#37

@stnguyen90 stnguyen90 added the product / storage Fixes and upgrades for the Appwrite Storage. label Dec 14, 2023
@eldadfux
Copy link
Member

We're in the process of reviewing a community PR to add a generic S3 adapter.

@stnguyen90
Copy link
Contributor

FYI, related S3 compatible adapter work: utopia-php/storage#28

@devNamanG
Copy link

Is this feature available in Appwrite now? Asking this since the related repo's PR for S3 compatible adapters has been merged.

@itexpertnow
Copy link

how to configure the s3 URL?

@devNamanG
Copy link

@itexpertnow I don't think it can be configured for Appwrite as of now.

@jeffdrumgod
Copy link

jeffdrumgod commented Aug 6, 2024

Hi guys!

I managed to get it working after making some adjustments. I am running everything locally in development mode.

I will try to send some PRs during the week to help you us.


But basically, I will take this opportunity to describe what I had to do. It was as follows:

  1. 📌 The latest version of the utopia-php/storage project is not the one with the most up-to-date code. ( requested here 🚀 Feature: Support for MINIO Object Storage utopia-php/storage#37 (comment))

  2. 📌 Even if you use the latest version of the project, there is still a need for validation in two scenarios:

My Scenario 1: When the host is something like: http://minio-server:9001/

In this scenario, the project is not validating whether the host value already has the protocol or not, and it is always inserting the HTTPS protocol.

Additionally, the same code is always forcing the existence of a "bucket" value, always leaving the URL with a subdomain, which causes a series of inconveniences.

Tip

Updated comment: created PR for item 2 utopia-php/storage#111

  1. 📌 Even after correcting these items, it is necessary to generate the most updated version of this utopia-php/storage package and make the appwrite project use it.

Waiting resolution of item 1 and 2

  1. 📌 After appwrite uses the updated package, it is still necessary for the ./appwrite/app file to use (from an environment variable) the URL of the Minio server host

Part of this resolution is in PR #7172
And then we need to make a new update to add the protocol variables and also pass them in the construction of new S3

@SOG-web
Copy link

SOG-web commented Sep 24, 2024

please any update on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product / storage Fixes and upgrades for the Appwrite Storage.
Projects
None yet
Development

No branches or pull requests

7 participants