Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New @newTab option for the AuLinkExternal component #496

Closed
Windvis opened this issue Jul 11, 2024 · 0 comments · Fixed by #524
Closed

New @newTab option for the AuLinkExternal component #496

Windvis opened this issue Jul 11, 2024 · 0 comments · Fixed by #524
Labels
enhancement Used when the PR adds a new feature or enhancement.

Comments

@Windvis
Copy link
Contributor

Windvis commented Jul 11, 2024

At the moment this component always adds the target="_blank" attribute.

This is fine for most use-cases, but for things like mailto, tel, or download links that isn't really needed. I think having the option to opt-out of the new tab would be a nice addition. It would default to true if not set, but can be used to explicitly disable it.
@Windvis Windvis added the enhancement Used when the PR adds a new feature or enhancement. label Jul 11, 2024
@Windvis Windvis mentioned this issue Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Used when the PR adds a new feature or enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a @newTab argument to the AuLinkExternal component appuniversum/ember-appuniversum
1 participant
@Windvis