Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reevaluate the date picker implementation #402

Open
Windvis opened this issue Jul 12, 2023 · 3 comments
Open

Reevaluate the date picker implementation #402

Windvis opened this issue Jul 12, 2023 · 3 comments

Comments

@Windvis
Copy link
Contributor

Windvis commented Jul 12, 2023

Do we still need a custom date picker library for this. Maybe the native one is good enough for our use cases now? (ignoring range pickers etc, which would probably be a different component anyways).

The duet date picker library we use hasn't been updated since the end of 2021 so it feels pretty unmaintained.

@Windvis
Copy link
Contributor Author

Windvis commented Sep 14, 2023

Issues I noticed with the native one:

  • the browser calendar icon can't be hidden in Firefox. This might be confusing if we also show the Appuniversum icon in there
  • The implementation is browser specific and some of them have some weird UX. Not sure if this is an issue for users
  • no control over the date formatting. It selects one based on your browser language which might not match the one used in other parts of the app

@aliokan
Copy link

aliokan commented Feb 7, 2024

@Windvis Any plan to move forward on this topic?

@Windvis
Copy link
Contributor Author

Windvis commented Feb 7, 2024

Not really. The current date picker project seems dead, but the native one doesn't seem ideal either, from what I can read in my previous comment. Not sure what to do with this, other than researching other date picker libraries maybe. But it's not a blocker for a project that I work on, so I haven't looked into it.

Is there anything specific you want to see?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants