Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 404 and error page examples #384

Open
Windvis opened this issue Feb 23, 2023 · 1 comment
Open

Add 404 and error page examples #384

Windvis opened this issue Feb 23, 2023 · 1 comment
Labels
enhancement Used when the PR adds a new feature or enhancement. UI/UX team An issue that requires input from the UI/UX team

Comments

@Windvis
Copy link
Contributor

Windvis commented Feb 23, 2023

All apps (should) use these in some form, so it would be nice if they all implement this somewhat consistently.

We could add examples to the templates section in the Storybook docs, or add components if that makes sense but we need a design first.

Some examples I found on existing websites:

image

@Windvis Windvis added the enhancement Used when the PR adds a new feature or enhancement. label Feb 23, 2023
@Windvis Windvis added the UI/UX team An issue that requires input from the UI/UX team label Jul 31, 2024
@Windvis
Copy link
Contributor Author

Windvis commented Jul 31, 2024

Ideally we have a similar style of layout for the generic "Something went wrong" page, with a nice illustration, but different from the "not found" one.

Once we have that we can probably add some sort of "" component that is configurable somewhat.

This PR implements this somewhat already, but it needs to be refined some more before we add it here: lblod/frontend-worship-decisions#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Used when the PR adds a new feature or enhancement. UI/UX team An issue that requires input from the UI/UX team
Projects
None yet
Development

No branches or pull requests

1 participant