Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone numbers #272

Open
nbittich opened this issue Jun 1, 2022 · 2 comments
Open

Phone numbers #272

nbittich opened this issue Jun 1, 2022 · 2 comments
Labels
enhancement Used when the PR adds a new feature or enhancement.

Comments

@nbittich
Copy link

nbittich commented Jun 1, 2022

Make the pattern easier to follow and the data more consistent by already providing land codes and flags for delight in a drop down (e.g below).

I've found this addon which looks pretty close: https://qonto.github.io/ember-phone-input/docs/usage

image

@Dietr Dietr added the enhancement Used when the PR adds a new feature or enhancement. label Jun 10, 2022
@iurianu iurianu self-assigned this Jun 30, 2022
@Windvis
Copy link
Contributor

Windvis commented Jul 11, 2022

Do we need this to be part of Appuniversum? Don't most of our projects deal with Belgian based phone numbers? Phone number validation usually uses some rather big js libraries which we would ship to all projects, even if they don't use it. The ember-phone-input addon does seem to provide a lazy-load option though so maybe the extra weight can be ignored in apps that don't use it.

@nbittich Where does the image come from? Is that a mockup of how this should be implemented, or just an example?

@nbittich
Copy link
Author

@Windvis it comes from the gitbook of appuniversum => https://app.gitbook.com/o/-MP9Yduzf5xu7wIebqPG/s/-MV0jY_qXNJed_-aeOPm/research-and-ongoing/form-validation-and-errors#phone-numbers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Used when the PR adds a new feature or enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants