chore: Removing unused styles, extra space in entity item and passing button condition prop

[ankitakinger]

Description

• Removing unused styles and extra space between icon and entity name in entity item component
• Passing button condition prop that is missing to show the warning icon on Data tab in sidebar, when there are no datasources connected in the workspace

Fixes #37675

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12009273207
Commit: f4bc4ab
Cypress dashboard.
Tags: @tag.IDE
Spec:

---

Mon, 25 Nov 2024 12:15:09 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Introduced a condition property for enhanced button configuration in the sidebar.
  • Added an optional preRightIcon property to the Entity component for improved icon customization.

• Bug Fixes

  • Simplified styling of the IconWrapper, potentially improving icon display.

[coderabbitai]

Walkthrough

The changes introduce a new condition property to the SidebarButton component within the IDESidebar, enhancing button configuration. Additionally, the Entity component in index.tsx has been modified to simplify the IconWrapper styling and includes a new optional property, preRightIcon, in the EntityProps interface. These modifications maintain the overall functionality of both components while allowing for greater customization and flexibility.

Changes

File Path	Change Summary
app/client/src/IDE/Components/Sidebar/Sidebar.tsx	Added condition property to SidebarButton component in IDESidebar.
app/client/src/pages/Editor/Explorer/Entity/index.tsx	Simplified IconWrapper styling; added preRightIcon property to EntityProps interface.

Possibly related PRs

• fix: show bindings menu does not appear in split mode #36378: Changes in EntityProperties.tsx involve conditional rendering based on the IDE view mode, potentially relating to the SidebarButton component's condition prop.
• fix: Adding permission check for the view tab on datasource editor #37308: Addition of permission checks in DatasourceTabs.tsx may connect to the SidebarButton component's configuration, as both involve conditionally rendered UI elements.
• fix: misc Button implementations not using isIconButton prop #37382: Modifications to button properties, including the isIconButton prop, may relate to changes in the SidebarButton component, focusing on button configurations.

Suggested labels

Bug, Task, IDE Product, IDE Pod, skip-changelog, ok-to-test

Suggested reviewers

• albinAppsmith

🎉 In the sidebar, buttons now gleam,
With conditions that flow like a dream.
Icons arranged with a pre-right flair,
The Entity shines with style to spare!
Simplified wrappers, a sight to behold,
In our IDE, new stories unfold! 🌟

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c55e98b and f4bc4ab.

📒 Files selected for processing (2)

• app/client/src/IDE/Components/Sidebar/Sidebar.tsx (2 hunks)
• app/client/src/pages/Editor/Explorer/Entity/index.tsx (0 hunks)

💤 Files with no reviewable changes (1)

• app/client/src/pages/Editor/Explorer/Entity/index.tsx

🔇 Additional comments (2)

app/client/src/IDE/Components/Sidebar/Sidebar.tsx (2)

Line range hint 42-49: LGTM: Consistent implementation

The condition prop is consistently implemented across both top and bottom button mappings, maintaining code symmetry and predictable behavior.

Also applies to: 56-63

---

42-42: ⚠️ Potential issue

Verify type definition for the condition prop

The condition prop is being passed to SidebarButton, but it's not defined in the IDESidebarButton interface. This could lead to type-safety issues.

Add the condition property to the IDESidebarButton interface:

export interface IDESidebarButton
  extends Omit<SidebarButtonProps, "onClick" | "selected"> {
  state: EditorState;
  urlSuffix: string;
+ condition?: boolean; // Add this line if boolean is the expected type
}

Also applies to: 56-56

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.