Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow currentRow for onClick in menuButton item in Table widget #35381

Closed
wants to merge 1 commit into from
Closed

fix: allow currentRow for onClick in menuButton item in Table widget #35381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...ypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/ColumnTypeMenubutton_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,5 +163,15 @@ describe(
});
cy.get(".table-menu-button-popover li a").should("not.exist");
});
it("5. should check that menuitems onClick property has access to currentRow", () => {
_.propPane.EnterJSContext("onClick", "");
_.propPane.TypeTextIntoField("onClick", "{{currentR");
_.agHelper.AssertElementExist(_.locators._hints);
_.agHelper.GetNAssertElementText(
_.locators._hints,
"currentRow",
"contain.text",
);
});
},
);
1 change: 1 addition & 0 deletions app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Basic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ export default {
isBindProperty: true,
isTriggerProperty: true,
dependencies: ["primaryColumns", "columnOrder"],
customJSControl: "TABLE_COMPUTE_VALUE",
},
],
},
Expand Down