Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Update UI for Response tab #35290

Open
15 tasks done
Tracked by #34663
albinAppsmith opened this issue Jul 30, 2024 · 1 comment · May be fixed by #37640
Open
15 tasks done
Tracked by #34663

[Task]: Update UI for Response tab #35290

albinAppsmith opened this issue Jul 30, 2024 · 1 comment · May be fixed by #37640
Assignees
@alex-golovanov
Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Milestone
Action Redesign :...

Comments

@albinAppsmith
Copy link
Collaborator

albinAppsmith commented Jul 30, 2024 •
edited by alex-golovanov
Loading

Design: https://www.figma.com/design/8L9BXMzNTKboGWlHpdXyYP/Appsmith-IDE?node-id=210-43673&node-type=frame&t=p9u98o4zLQEOBVGN-0

Prototype: https://www.figma.com/proto/8L9BXMzNTKboGWlHpdXyYP/Appsmith-IDE?page-id=174%3A9578&node-id=177-8814&node-type=frame&viewport=579%2C-2119%2C0.46&t=XoWvJeqb22Frosmz-1&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=177%3A8814&show-proto-sidebar=1

Video explanation: https://www.loom.com/share/0584cc03faea4a61b09b30a8e7e276fd?sid=b260d208-28e7-48cd-814d-8aa208571aaa

Definition of done:

  • Add query name .run as prefix for the header row. This uses code variant of ads text component. (design)
  • Move number of records to the new header component.
  • Acquire query duration & HTTP status and add request execution time to redux.
  • On hover of query name and number of records, meta data of api run (outlined above) should show up as tooltip. (design)
  • Move bind data button to the new header component & change its title in the process. (design)
  • Add content type icons (table, json, raw) to ADS.
  • Change result type from segmented control to a FAB with dropdown menu.
  • Change loading state button/spinner/spacing. (design)
  • Change the empty state text and button alignment. (design)
  • Update table appearance.
  • Table columns have a fixed width of 170px now, this needs to be updated to min-width.
  • Add status bar to error state, hide bind to UI button.
  • Account for scrollbars that are always shown.
  • Add dashed underline for status bar fn name & meta.
  • Fix Cypress tests related to result type control change.
@albinAppsmith albinAppsmith mentioned this issue Jul 30, 2024
Open
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Jul 30, 2024
@github-actions github-actions bot mentioned this issue Jul 30, 2024
Closed
@albinAppsmith albinAppsmith added the IDE Navigation Issues/feature requests related to IDE navigation, and context switching label Jul 30, 2024
@github-actions github-actions bot added IDE Pod Issues that new developers face while exploring the IDE potential-duplicate This label marks issues that are potential duplicates of already open issues labels Jul 30, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the IDE Product Issues related to the IDE Product label Aug 5, 2024
@appsmithorg appsmithorg deleted a comment from github-actions bot Aug 8, 2024
@albinAppsmith albinAppsmith removed the potential-duplicate This label marks issues that are potential duplicates of already open issues label Aug 8, 2024
@albinAppsmith
Copy link
Collaborator Author

https://www.loom.com/share/0584cc03faea4a61b09b30a8e7e276fd?sid=b260d208-28e7-48cd-814d-8aa208571aaa

@albinAppsmith albinAppsmith mentioned this issue Nov 6, 2024
Closed
@alex-golovanov alex-golovanov mentioned this issue Nov 12, 2024
Closed
2 tasks
@alex-golovanov alex-golovanov linked a pull request Nov 21, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-golovanov alex-golovanov

Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
Action Redesign :: Wrap up
3 participants
@alex-golovanov @Nikhil-Nandagopal @albinAppsmith