Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record params in Koa only when in the router middleware #730

Closed
luismiramirez opened this issue Sep 16, 2022 · 2 comments
Closed

Record params in Koa only when in the router middleware #730

luismiramirez opened this issue Sep 16, 2022 · 2 comments
Assignees
Labels

Comments

@luismiramirez
Copy link
Member

The Koa requestHook is set up to record request params as magic attributes, but it differs from the Express one in that we don't check which middleware is triggering the request hook: https://github.com/appsignal/appsignal-nodejs/blob/opentelemetry/src/client.ts#L216-L228

We need to record the parameters in the span just when in the router middleware, setting them in all the middleware spans is not needed.

@tombruijn
Copy link
Member

Relevant issue for filtering those parameters when collected: https://github.com/appsignal/opentelemetry/issues/48

@tombruijn
Copy link
Member

tombruijn commented Oct 18, 2022

Blocked while we wait on the OpenTelemetry release.
open-telemetry/opentelemetry-js-contrib#1214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants